Add cycle creation utility and detection tests for Linked List (Fixes #583)#2052
Open
sowmya-rebbavarapu wants to merge 1 commit intotrekhleb:masterfrom
Open
Add cycle creation utility and detection tests for Linked List (Fixes #583)#2052sowmya-rebbavarapu wants to merge 1 commit intotrekhleb:masterfrom
sowmya-rebbavarapu wants to merge 1 commit intotrekhleb:masterfrom
Conversation
|
That's not a linked list anymore. |
Imran-imtiaz48
left a comment
There was a problem hiding this comment.
Great job on this test suite! Here are some specific observations and suggestions:
Positives
- Test Coverage: The tests cover a good range of scenarios, including:
- No cycle in the linked list
- Correct cycle creation and detection
- Handling invalid positions for cycle creation (out-of-bounds and negative)
- Readability: Test cases are clear and descriptive, making it easy to understand the intention behind each scenario.
- Setup: Using
beforeEachto initialize a newLinkedListkeeps tests isolated and reliable.
Suggestions/Improvements
-
Edge Cases:
Consider adding tests for these edge cases:- An empty list (should return false for cycle detection).
- A list with a single node (cycle vs. no cycle).
- Creating a cycle at position 0 (head node).
-
Assertions:
IfcreateCyclereturns a value (such as success/failure), consider asserting it as well to make the effect of the function explicit. -
Comments:
Your current comments are helpful! If possible, expand them a bit for maintainability, especially in less obvious scenarios. -
Consistency:
The pattern and naming are consistent and align with best practices for unit testing in JavaScript.
|
What a waste of GPU cycles. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This pull request adds the ability to create a cycle in the linked list by linking the tail node to any node at a specified position. It includes:
A utility function createCycle(list, position) that links the last node to the node at the given position to form a cycle.
Unit tests to verify cycle creation and detection using the existing detectCycle function.
Tests cover normal cases, invalid positions, and no-cycle scenarios.
This addresses the feature request in issue #583 opened by @chrisVillanueva, enabling users to create and detect cycles within linked lists for more comprehensive linked list operations.
Please review the implementation and tests. Looking forward to your feedback!