Skip to content

dijkstra algo fixed ,duplicate files removed#2064

Open
rahul4581 wants to merge 1 commit intotrekhleb:masterfrom
rahul4581:dijkstra-algo-fix
Open

dijkstra algo fixed ,duplicate files removed#2064
rahul4581 wants to merge 1 commit intotrekhleb:masterfrom
rahul4581:dijkstra-algo-fix

Conversation

@rahul4581
Copy link
Copy Markdown

Solved #2056
📝 Summary
This PR improves the Dijkstra algorithm implementation to ensure correct handling of priority updates for neighbors in the priority queue

🧠 Problem
In the current implementation, the neighbor’s priority in the queue is only updated if queue.hasValue(neighbor) returns true. This is logically sound only if the PriorityQueue:

Correctly changes the priority of an existing node, and

Does not contain duplicate entries.

If the PriorityQueue does not update priorities properly or allows duplicates, a node may exist multiple times in the queue with different costs — potentially breaking Dijkstra's guarantees.

✅ Fix
Explicitly ensure priority updates are handled correctly even if the node is already present in the queue.

Avoid potential issues caused by multiple entries of the same node with different priorities.

@lazarljubenovic
Copy link
Copy Markdown

Was it that hard writing it on your own?

@rahul4581
Copy link
Copy Markdown
Author

just trying to contribute in open source projects @lazarljubenovic bro

@lazarljubenovic
Copy link
Copy Markdown

Huh, looks like it is hard.

Copy link
Copy Markdown

@coursgranja01-del coursgranja01-del left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apply override to all files in the directory

special-vendored-path/* linguist-vendored

Apply override to a specific file

jquery.js -linguist-vendored

Apply override to all files and directories in the directory

ano-dir/** linguist-vendored

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants