Add resource related comments #364
Conversation
Had some problems launching the app with requests and limits set. Wanted to share some reasonable defaults with the community.
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
submitted the cla |
|
@cla-bot check |
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
The cla-bot has been summoned, and re-checked this pull request! |
| @@ -754,16 +759,20 @@ worker: | |||
| # worker.deployment.strategy -- The deployment strategy to use to replace existing pods with new ones. | |||
|
|
|||
| jvm: | |||
| # -- Should be around 70% of worker.resources memory values if set | |||
There was a problem hiding this comment.
We should link the Trino docs here (like these) instead of specifying concrete values.
Had some problems launching the app with requests and limits set. Wanted to share some reasonable defaults with the community.