Add support for passing header X-Trino-Client-Tags #309
Conversation
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
Realy usefull ! is it planned to release this soon ? |
|
Good job ! |
| async function setupDataSourceWithAccessToken(page: Page) { | ||
| await page.getByTestId('data-testid Datasource HTTP settings url').fill('http://trino:8080'); | ||
| await page.locator('div').filter({hasText: /^Impersonate logged in userAccess token$/}).getByLabel('Toggle switch').click(); | ||
| await page.locator('#trino-settings-enable-impersonation').click({ force: true }); |
There was a problem hiding this comment.
Why is it in the same pr? is it related to the client tags?
There was a problem hiding this comment.
The CI tests were failing so I just fixed it here. Should I revert it?
There was a problem hiding this comment.
In my opinion it should be a separated pr, taging a contributor that had merged pr recently. @nineinchnick
There was a problem hiding this comment.
How do I fix the failing unit tests then?
There was a problem hiding this comment.
yes, @nineinchnick let me know if I should create a new MR for this minor fix
There was a problem hiding this comment.
That would be ideal, but also see #303 where I'm trying to refactor tests to run on the latest and newest supported Grafana versions. This is required for publishing a new release, but I'm blocked there since I don't know Playwright.
There was a problem hiding this comment.
#318
I also don't know Playwright. I can take a look using Copilot if there is no one else to take a look.
|
@laserninja pls address |
Co-authored-by: Rotem Albukrek <[email protected]>
Co-authored-by: Rotem Albukrek <[email protected]>
| async function setupDataSourceWithAccessToken(page: Page) { | ||
| await page.getByTestId('data-testid Datasource HTTP settings url').fill('http://trino:8080'); | ||
| await page.locator('div').filter({hasText: /^Impersonate logged in userAccess token$/}).getByLabel('Toggle switch').click(); | ||
| await page.locator('#trino-settings-enable-impersonation').click({ force: true }); |
There was a problem hiding this comment.
In my opinion it should be a separated pr, taging a contributor that had merged pr recently. @nineinchnick
Add support for X-Trino-Client-Tags header
Description
This PR adds support for the
X-Trino-Client-Tagsheader in the Grafana Trino datasource plugin. TheX-Trino-Client-Tagsheader is part of the official Trino client protocol and allows sending a comma-separated list of tag strings to identify Trino resource groups, which is useful for resource management and query monitoring.How to Use
grafana,dashboard,analytics)The tags will be automatically sent with every query to help Trino administrators identify and manage resource usage from different client sources.
Technical Details
X-Trino-Client-Tagsheader is only sent when client tags are configured (optional field)Testing
References