Enhance the MultiReadHttpServletRequest stream #721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Typo in commit message. MultiReadHttpServletReques |
oneonestar
reviewed
Jul 11, 2025
Comment on lines
+67
to
+68
| @Override | ||
| public int read(byte[] b, int off, int len) |
There was a problem hiding this comment.
Should we also implement public int read(byte[] b)?
RoeyoOgen
reviewed
Jul 13, 2025
| public int read(byte[] b, int off, int len) | ||
| throws IOException | ||
| { | ||
| return byteArrayInputStream.read(b, off, len); |
There was a problem hiding this comment.
do we want to make this null-safe?
There was a problem hiding this comment.
byteArrayInputStream is locally allocated, if that's what your concern is. It should not be null.
|
Is this good to to @vishalya @Chaho12 @oneonestar ? |
|
Seems ok. But don't forget to fix the commit message :) |
andythsu
reviewed
Jul 18, 2025
vishalya
changed the title
vishalya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MultiReadHttpServletRequest class returns the stream with the cached body of the request. But the overriden methods logic look wrong. Also giving an option to multiple bytes for better performance.
Additional context and related issues
@Chaho12 has idea on the issue with this code. @willmostly is the original author.
Release notes
(X) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required, with the following suggested text: