feat: add jwt auth (#524) #855
Conversation
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
emmc15
changed the title
emmc15
requested review from
wendigo and
nineinchnick
and removed request for
mosabua and
regadas
|
Apologizes, I seemed to have requested reviews from incorrect maintainers. Please let me know if I’ve requested the right people if you know. if there’s anything needed for the PR or changes, also please let me know. Thank you! |
| @@ -35,6 +35,12 @@ export class BasicAuth implements Auth { | |||
| constructor(readonly username: string, readonly password?: string) {} | |||
| } | |||
|
|
|||
| export class JwtAuth implements Auth { | |||
There was a problem hiding this comment.
This is not a correct implementation. It should be closer to the implementation like the one in the python client: https://github.com/trinodb/trino-python-client/blob/df08367b54d7d27c1cd826ca3fa34ca0173f4c63/trino/auth.py#L295
Issue
Adds a simple Auth for JWT (accessToken in Trino JDBC)
Added very simple test to validate JWT is being passed correctly through the client.
Bumped
package.jsonversion for release.