Fix Pinot connector to respect pinot.broker-url when proxy is enabled #26170
Conversation
shreyas-dev
force-pushed
the
fix-pinot-broker-url
branch
from
648c034 to
7de70b5
Compare
| brokerHostAndPort = config.getBrokerUrl(); | ||
| this.brokerHostAndPort = config.getBrokerUrl(); | ||
|
|
||
| if (this.brokerHostAndPort.isPresent() && this.proxyEnabled) { |
There was a problem hiding this comment.
This should be validated in the config class and rejected instead
shreyas-dev
force-pushed
the
fix-pinot-broker-url
branch
from
7de70b5 to
a96b3be
Compare
…l and proxy.enabled
shreyas-dev
force-pushed
the
fix-pinot-broker-url
branch
from
a96b3be to
e112180
Compare
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
shreyas-dev
force-pushed
the
fix-pinot-broker-url
branch
from
404aa47 to
2721942
Compare
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
shreyas-dev
force-pushed
the
fix-pinot-broker-url
branch
from
2721942 to
605ab9d
Compare
shreyas-dev
force-pushed
the
fix-pinot-broker-url
branch
from
605ab9d to
734ba83
Compare
|
|
Description
Add configuration validation to prevent conflicting
pinot.broker-urlandpinot.proxy.enabledsettings in the Pinot connector.Previously, users could configure both
pinot.broker-urlandpinot.proxy.enabled=truesimultaneously, which would result in confusing behavior where the explicit broker URL would silently take precedence over the proxy setting without any indication to the user.Changes made:
@AssertTruevalidation inPinotConfig.isValidBrokerProxyConfiguration()to reject conflicting settingsRelated to: #25747
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: