Added group name case conversion #26195

gertjanal · 2025-07-14T09:58:27Z

Description

Added the property group-provider.group-case to etc/group-provider.properties with the following configuration options:

keep
lower
upper

Additional context and related issues

This change allows conversion of group names to uppercase and lowercase, to allow integration with Apache Ranger where silimar conversion is used; ranger.usersync.ldap.groupname.caseconversion = upper.

In a previous iteration I added this property to the LdapGroupProviderConfig, but I think it is better to allow the property to be set on all GroupProvider implementations.

Fixes #25396

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( X) Release notes are required, with the following suggested text:

## Group providers
* Added support for group name case conversion in the group provider properties. ({issue}`25396`)

cla-bot · 2025-07-14T09:58:30Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2025-07-14T09:59:33Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2025-07-14T09:59:46Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

gertjanal · 2025-07-14T10:04:45Z

@MiguelWeezardo @mosiac1 Can you please review my changes?

cla-bot · 2025-07-14T10:20:02Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2025-07-14T10:46:54Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2025-07-14T10:47:37Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2025-07-14T11:00:06Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2025-07-14T11:00:48Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2025-07-14T16:02:48Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2025-07-16T19:59:33Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot · 2025-07-25T13:03:40Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

kokosing

Some nit comments. Thank you!

core/trino-main/src/main/java/io/trino/security/GroupProviderManager.java

docs/src/main/sphinx/develop/group-provider.md

kokosing · 2025-08-05T10:18:28Z

Please rebase properly and squash commits.

docs/src/main/sphinx/security/group-mapping/file.md

core/trino-main/src/main/java/io/trino/util/Case.java

docs/src/main/sphinx/release/release-344.md

mosabua

Just did a doc review ... and left change requests for that. Ping me again when that is all updated

docs/src/main/sphinx/security/group-mapping/file.md

mosabua · 2025-08-30T20:48:43Z

docs/src/main/sphinx/security/overview.md

  usernames from other systems (`[email protected]`) to simple usernames
  (`alice`).
- {doc}`File group provider <group-file>` provides a way to assign a set
+- {doc}`Group mapping <group-mapping>` provides ways to assign a set


Why are we renaming this?

Because the file group provider is not the only supported provider and because the name of the md was changed

docs/src/main/sphinx/security/group-mapping.md

docs/src/main/sphinx/security/group-mapping/file.md

mosabua

Docs look good now. Thank you. Should we go ahead and merge @kokosing ?

kokosing

% one comment

core/trino-main/src/main/java/io/trino/util/Case.java

kokosing · 2025-09-12T13:48:06Z

core/trino-main/src/main/java/io/trino/security/GroupProviderManager.java

 import com.google.inject.Inject;
 import io.airlift.configuration.secrets.SecretsResolver;
 import io.airlift.log.Logger;
 import io.trino.spi.classloader.ThreadContextClassLoader;


I will merge that once the release goes out. I don't want to mess with release notes at the moment.

Add configuration property group-provider.group-case={keep/upper/lower}

github-actions bot added the docs label Jul 14, 2025

gertjanal force-pushed the group-provider-group-case branch from 1c671ac to efc293c Compare July 14, 2025 11:00

gertjanal force-pushed the group-provider-group-case branch from efc293c to 8f112a3 Compare July 14, 2025 11:00

gertjanal force-pushed the group-provider-group-case branch from 8f112a3 to 294612e Compare July 14, 2025 16:02

fathom-MichalSlizak approved these changes Jul 15, 2025

View reviewed changes

gertjanal force-pushed the group-provider-group-case branch from 294612e to 3a250e3 Compare July 16, 2025 19:59

gertjanal force-pushed the group-provider-group-case branch from 3a250e3 to 67cd616 Compare July 25, 2025 13:03

gertjanal force-pushed the group-provider-group-case branch from 67cd616 to 2ecd031 Compare July 25, 2025 19:19

cla-bot bot added the cla-signed label Jul 25, 2025

gertjanal self-assigned this Jul 27, 2025

gertjanal force-pushed the group-provider-group-case branch from 2ecd031 to 2ee6a9a Compare July 28, 2025 21:22

raunaqmorarka requested a review from kokosing July 30, 2025 08:41

kokosing approved these changes Aug 1, 2025

View reviewed changes

github-actions bot added release-notes iceberg Iceberg connector delta-lake Delta Lake connector labels Aug 5, 2025

gertjanal force-pushed the group-provider-group-case branch from d138923 to e349c8f Compare August 5, 2025 10:22

gertjanal force-pushed the group-provider-group-case branch 2 times, most recently from e1b8c2a to cab059d Compare August 26, 2025 20:04

github-actions bot removed the stale label Aug 27, 2025

gertjanal force-pushed the group-provider-group-case branch 5 times, most recently from 8f57d98 to 0851a8f Compare August 29, 2025 20:48

mosabua reviewed Aug 30, 2025

View reviewed changes

docs/src/main/sphinx/security/group-mapping/file.md Outdated Show resolved Hide resolved

mosabua reviewed Aug 30, 2025

View reviewed changes

docs/src/main/sphinx/security/group-mapping/file.md Outdated Show resolved Hide resolved

chenjian2664 reviewed Aug 30, 2025

View reviewed changes

core/trino-main/src/main/java/io/trino/util/Case.java Outdated Show resolved Hide resolved

mosabua reviewed Aug 30, 2025

View reviewed changes

docs/src/main/sphinx/release/release-344.md Outdated Show resolved Hide resolved

mosabua requested changes Aug 30, 2025

View reviewed changes

gertjanal force-pushed the group-provider-group-case branch from 0851a8f to 197a4fb Compare September 3, 2025 20:02

gertjanal requested a review from mosabua September 3, 2025 20:05

gertjanal force-pushed the group-provider-group-case branch from 197a4fb to 6bd1503 Compare September 3, 2025 20:05

gertjanal requested a review from chenjian2664 September 3, 2025 20:09

gertjanal force-pushed the group-provider-group-case branch 2 times, most recently from d8afbaa to 1fb67df Compare September 10, 2025 18:39

mosabua approved these changes Sep 10, 2025

View reviewed changes

kokosing approved these changes Sep 11, 2025

View reviewed changes

core/trino-main/src/main/java/io/trino/util/Case.java Outdated Show resolved Hide resolved

gertjanal force-pushed the group-provider-group-case branch 3 times, most recently from 618cbeb to 8a2fae2 Compare September 11, 2025 19:14

kokosing reviewed Sep 12, 2025

View reviewed changes

Add support for group name case conversion in the user group mapping

d5e142e

Add configuration property group-provider.group-case={keep/upper/lower}

gertjanal force-pushed the group-provider-group-case branch from 8a2fae2 to d5e142e Compare September 12, 2025 18:53

kokosing merged commit 6b59de9 into trinodb:master Sep 18, 2025
98 of 99 checks passed

github-actions bot added this to the 477 milestone Sep 18, 2025

gertjanal deleted the group-provider-group-case branch September 18, 2025 18:40

Added group name case conversion #26195

Added group name case conversion #26195

Uh oh!

Conversation

gertjanal commented Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Additional context and related issues

Release notes

Uh oh!

cla-bot bot commented Jul 14, 2025

Uh oh!

cla-bot bot commented Jul 14, 2025

Uh oh!

cla-bot bot commented Jul 14, 2025

Uh oh!

gertjanal commented Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cla-bot bot commented Jul 14, 2025

Uh oh!

cla-bot bot commented Jul 14, 2025

Uh oh!

cla-bot bot commented Jul 14, 2025

Uh oh!

cla-bot bot commented Jul 14, 2025

Uh oh!

cla-bot bot commented Jul 14, 2025

Uh oh!

cla-bot bot commented Jul 14, 2025

Uh oh!

cla-bot bot commented Jul 16, 2025

Uh oh!

cla-bot bot commented Jul 25, 2025

Uh oh!

kokosing left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kokosing commented Aug 5, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mosabua left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mosabua Aug 30, 2025

Choose a reason for hiding this comment

Uh oh!

gertjanal Sep 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mosabua left a comment

Choose a reason for hiding this comment

Uh oh!

kokosing left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kokosing Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

gertjanal commented Jul 14, 2025 •

edited

Loading

gertjanal commented Jul 14, 2025 •

edited

Loading