-
Notifications
You must be signed in to change notification settings - Fork 3.3k
MySQL EventListener: Ignore schema creation errors on startup if MySQL is down #26254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
MySQL EventListener: Ignore schema creation errors on startup if MySQL is down #26254
Conversation
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
...sql-event-listener/src/main/java/io/trino/plugin/eventlistener/mysql/MysqlEventListener.java
Outdated
Show resolved
Hide resolved
...sql-event-listener/src/main/java/io/trino/plugin/eventlistener/mysql/MysqlEventListener.java
Show resolved
Hide resolved
a3f1164
to
7e211c7
Compare
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
1 similar comment
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
a3d2f77
to
1c755fc
Compare
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
1c755fc
to
d3ea939
Compare
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
d3ea939
to
7b7bd7d
Compare
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
...sql-event-listener/src/main/java/io/trino/plugin/eventlistener/mysql/MysqlEventListener.java
Outdated
Show resolved
Hide resolved
...sql-event-listener/src/main/java/io/trino/plugin/eventlistener/mysql/MysqlEventListener.java
Outdated
Show resolved
Hide resolved
...ent-listener/src/main/java/io/trino/plugin/eventlistener/mysql/MysqlEventListenerConfig.java
Outdated
Show resolved
Hide resolved
Please follow the commit message guideline. https://trino.io/development/process.html#pull-request-and-commit-guidelines- |
7b7bd7d
to
3d3ddac
Compare
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
Add a new configuration key, `mysql-event-listener.terminate-on-initialization-failure`, to control how Trino behaves when the MySQL database is unreachable during startup. Previously, Trino would fail to start if MySQL was down. With this option, users can choose whether startup should fail or continue, improving resilience and flexibility in various deployment scenarios.
3d3ddac
to
71184bd
Compare
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
Description
Currently, when the Trino coordinator starts, the MySQL Event Listener plugin attempts to connect to the MySQL database to validate the schema. However, if the MySQL server is temporarily unavailable (e.g., during restart or maintenance), the coordinator fails to start entirely, causing the entire Trino service to remain offline.
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(X) Release notes are required, with the following suggested text:
Closes: #26252