Add http-event-listener.connect-http-headers.config-file to support special characters in header values #26415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielbelchior
force-pushed
the
add-header-file-configuration-to-http-event-listener
branch
from
9ce36cb to
d9ce568
Compare
ebyhr
reviewed
Aug 17, 2025
...ino-http-event-listener/src/main/java/io/trino/plugin/httpquery/HttpEventListenerConfig.java
Outdated
Show resolved
Hide resolved
...ino-http-event-listener/src/main/java/io/trino/plugin/httpquery/HttpEventListenerConfig.java
Outdated
Show resolved
Hide resolved
...http-event-listener/src/test/java/io/trino/plugin/httpquery/TestHttpEventListenerConfig.java
Outdated
Show resolved
Hide resolved
...http-event-listener/src/test/java/io/trino/plugin/httpquery/TestHttpEventListenerConfig.java
Outdated
Show resolved
Hide resolved
...http-event-listener/src/test/java/io/trino/plugin/httpquery/TestHttpEventListenerConfig.java
Outdated
Show resolved
Hide resolved
...ino-http-event-listener/src/main/java/io/trino/plugin/httpquery/HttpEventListenerConfig.java
Outdated
Show resolved
Hide resolved
...ino-http-event-listener/src/main/java/io/trino/plugin/httpquery/HttpEventListenerConfig.java
Outdated
Show resolved
Hide resolved
danielbelchior
force-pushed
the
add-header-file-configuration-to-http-event-listener
branch
4 times, most recently
from
8db5537 to
592debd
Compare
ebyhr
reviewed
Aug 17, 2025
...ino-http-event-listener/src/main/java/io/trino/plugin/httpquery/HttpEventListenerConfig.java
Outdated
Show resolved
Hide resolved
...ino-http-event-listener/src/main/java/io/trino/plugin/httpquery/HttpEventListenerConfig.java
Outdated
Show resolved
Hide resolved
...http-event-listener/src/test/java/io/trino/plugin/httpquery/TestHttpEventListenerConfig.java
Outdated
Show resolved
Hide resolved
...http-event-listener/src/test/java/io/trino/plugin/httpquery/TestHttpEventListenerConfig.java
Outdated
Show resolved
Hide resolved
...http-event-listener/src/test/java/io/trino/plugin/httpquery/TestHttpEventListenerConfig.java
Outdated
Show resolved
Hide resolved
danielbelchior
force-pushed
the
add-header-file-configuration-to-http-event-listener
branch
6 times, most recently
from
cce33d2 to
3f34f65
Compare
github-actions
bot
added
iceberg
danielbelchior
force-pushed
the
add-header-file-configuration-to-http-event-listener
branch
from
95c3660 to
592debd
Compare
Introduces the `http-event-listener.connect-http-headers.config-file` property to allow defining custom HTTP headers in an external file using `key=value` pairs. This supports header names and values containing commas (`,`) or colons (`:`), which are not supported in the inline `http-event-listener.connect-http-headers` property. Only one of `http-event-listener.connect-http-headers` or `http-event-listener.connect-http-headers.config-file` may be set. An exception will be raised if both are configured.
danielbelchior
force-pushed
the
add-header-file-configuration-to-http-event-listener
branch
from
592debd to
561e52a
Compare
|
This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses #26187 by adding a new property,
http-event-listener.connect-http-headers.config-file, that allows defining custom HTTP headers in an external configuration file.Key changes:
http-event-listener.connect-http-headers.config-fileproperty.,) or colons (:) that are not supported in the inlinehttp-event-listener.connect-http-headersproperty.key=valuepair per line.http-event-listener.connect-http-headersorhttp-event-listener.connect-http-headers.config-fileis set,otherwise an exception is thrown at startup.
This enhancement ensures correct handling of special characters in HTTP header values, which was not possible with the existing inline configuration format.
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(X) Release notes are required, with the following suggested text:
Closes #26187