-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Add query stages view to Preview Web UI #26440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1e4d131
to
378121e
Compare
2fd32b7
to
e3b545e
Compare
e3b545e
to
a1006d7
Compare
9fb5452
to
d6a355f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried the latest version of the code and all features are working as expected. Thanks @koszti for the contribution.
core/trino-web-ui/src/main/resources/webapp-preview/src/components/QueryOverview.tsx
Outdated
Show resolved
Hide resolved
d6a355f
to
1938ba6
Compare
1938ba6
to
1379c86
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a query stages view to the Preview Web UI, providing detailed stage-level information with improved layout and design compared to the existing web UI.
Key changes include:
- Addition of stage visualization with collapsible cards showing state, timing, memory, and task statistics
- Interactive task tables with sorting and filtering capabilities
- Worker task information modal with JSON details
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.
File | Description |
---|---|
utils.ts | Added utility functions for stage/task ID parsing, hostname extraction, rate computation, and duration formatting |
QueryStageCard.tsx | New component implementing comprehensive stage visualization with task management and worker details |
QueryOverview.tsx | Integration of stages view into main query overview page |
api.ts | Extended API types to support stage, task, and worker task information |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Description
Add query stages view to the preview UI. Partially addressing #22697
Additional context and related issues
Retains the same functionality as the existing web UI, enhanced with the updated layout, design, and user experience.
Screenshots
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: