Don't encode crs in GeoJSON #26499
Merged
Don't encode crs in GeoJSON #26499
+37
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please shorten commit message. You can just move the second sentence into next line. |
umartin
force-pushed
the
remove_crs_from_geojson
branch
from
acad5c9 to
8ab5c10
Compare
Done |
|
Sorry, I accidentally closed the PR. Opening again |
|
Please remove the following period from the commit title. https://trino.io/development/process.html#pull-request-and-commit-guidelines- |
ebyhr
reviewed
Aug 27, 2025
lib/trino-geospatial-toolkit/src/main/java/io/trino/geospatial/GeometryUtils.java
Show resolved
Hide resolved
ebyhr
changed the title
umartin
force-pushed
the
remove_crs_from_geojson
branch
from
8ab5c10 to
cf87e8c
Compare
wendigo
reviewed
Aug 27, 2025
lib/trino-geospatial-toolkit/src/test/java/io/trino/geospatial/GeometryUtilsTest.java
Outdated
Show resolved
Hide resolved
ebyhr
reviewed
Aug 27, 2025
lib/trino-geospatial-toolkit/src/test/java/io/trino/geospatial/GeometryUtilsTest.java
Outdated
Show resolved
Hide resolved
umartin
force-pushed
the
remove_crs_from_geojson
branch
from
cf87e8c to
01c8b2c
Compare
The crs attribute is no longer allowed in GeoJSON per https://datatracker.ietf.org/doc/html/rfc7946#section-4.
wendigo
force-pushed
the
remove_crs_from_geojson
branch
from
01c8b2c to
20f4d8a
Compare
wendigo
approved these changes
Sep 2, 2025
|
Applied small nits and going to merge soon |
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Don't encode crs in GeoJSON. The crs attribute is no longer allowed in GeoJSON: https://datatracker.ietf.org/doc/html/rfc7946#section-4. It is also pointless in trino since geometries are stripped of srid. It will always be 0 (unknown).
Additional context and related issues
Split from #26451
Release notes
I don't think a release note is required. Compliant GeoJSON consumers should ignore the crs attribute. For completeness a note could be added.
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: