WIP: Test Jetty https://github.com/jetty/jetty.project/pull/13694

[wendigo]

Description

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

Summary by Sourcery

Switch to a Jetty 12 snapshot for testing by updating the dependency, adding the snapshot repo, and restoring HTTP compression in the server configuration.

Enhancements:

• Upgrade Jetty dependency to 12.1.3-SNAPSHOT
• Add a Maven snapshot repository for Apache snapshots
• Re-enable HTTP server compression by commenting out the disable setting

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the Jetty dependency to a 12.1.3-SNAPSHOT (with a new snapshot repository) and restores the default HTTP compression setting by commenting out the previous disabling code.

Class diagram for updated HttpServerConfig compression setting

classDiagram
    class HttpServerConfig {
        +int http2MaxConcurrentStreams
        +boolean compressionEnabled
        +setHttp2MaxConcurrentStreams(int)
        +setCompressionEnabled(boolean)
    }
    %% Note: compressionEnabled is now left at its default value (restored), as disabling is commented out.

Loading

File-Level Changes

Change	Details	Files
Update Jetty dependency and add snapshot repository	Bump dep.jetty.version to 12.1.3-SNAPSHOT Introduce apache-snapshots repository entry	pom.xml
Re-enable HTTP compression in server configuration	Comment out the explicit disabling of compression in HttpServerConfig defaults	core/trino-main/src/main/java/io/trino/server/ServerMainModule.java

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes - here's some feedback:

• Consider wrapping the apache-snapshots repository in a dedicated Maven profile so snapshot dependencies don’t leak into all builds by default.
• Once the upstream Jetty fix is merged, clean up the commented-out setCompressionEnabled(false) line to avoid retaining dead code.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Consider wrapping the apache-snapshots repository in a dedicated Maven profile so snapshot dependencies don’t leak into all builds by default.
- Once the upstream Jetty fix is merged, clean up the commented-out setCompressionEnabled(false) line to avoid retaining dead code.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}