Skip to content

Fix query splits timeline in preview UI to prevent blank screen #26920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2025
Merged

Fix query splits timeline in preview UI to prevent blank screen #26920

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 27 additions & 16 deletions core/trino-web-ui/src/main/resources/webapp-preview/src/components/QuerySplitsTimeline.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,8 +177,11 @@ export const QuerySplitsTimeline = () => {
return <Alert severity="info">No split timeline data available.</Alert>
}

const timelineStartTime = items.reduce((min, item) => Math.min(min, item.start_time), items[0].start_time)
const timelineEndTime = items.reduce((max, item) => Math.max(max, item.end_time), items[0].end_time)
const startTimes = items.map((i) => i.start_time).filter(Number.isFinite)
const endTimes = items.map((i) => i.end_time).filter(Number.isFinite)

const timelineStartTime = startTimes.length ? Math.min(...startTimes) : null
const timelineEndTime = endTimes.length ? Math.max(...endTimes) : null

const itemRenderer: TimelineItemRenderer = ({ item, itemContext, getItemProps }: TimelineItemRendererProps) => {
const splitItem = item as SplitTimelineItem
Expand Down Expand Up @@ -286,20 +289,28 @@ export const QuerySplitsTimeline = () => {
))}
</Box>

<Timeline
groups={groups}
items={items}
defaultTimeStart={timelineStartTime}
defaultTimeEnd={timelineEndTime}
itemRenderer={itemRenderer}
minZoom={60 * 1000}
itemHeightRatio={0.65}
itemTouchSendsClick={false}
canMove={false}
canResize={false}
stackItems
// traditionalZoom
/>
{timelineStartTime && timelineEndTime ? (
<Timeline
groups={groups}
items={items}
defaultTimeStart={timelineStartTime}
defaultTimeEnd={timelineEndTime}
itemRenderer={itemRenderer}
minZoom={60 * 1000}
itemHeightRatio={0.65}
itemTouchSendsClick={false}
canMove={false}
canResize={false}
stackItems
// traditionalZoom
/>
) : (
<Box sx={{ width: '100%', mt: 1 }}>
<Alert severity="info">
Splits timeline will appear automatically when at least one query task starts running
</Alert>
</Box>
)}
</Box>
)
}
Expand Down
Loading