-
Notifications
You must be signed in to change notification settings - Fork 77
Fix DAS tests job #1012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DAS tests job #1012
Conversation
1 - 2 - That's odd, will ping my team to improve that. 3 - Let's try pip install it using 4 - Agree, but I'm not a Github Actions expert so not sure how to do that =/ |
Agree
Well, I removed |
Oh I see, yeah let's not remove the TEMP dir...that should work |
Btw, it probably should be the part of
If |
The |
I mean should be installed by |
I just ran these lines on Ubuntu 24.04 and it worked:
|
Yeah, I see the point. We can add it to the job to see if it works inside GitHub container. But my point is that may be DAS cli installation should be fixed if it is distributed as a standalone application. |
What if someone gets the das-cli code and perform |
Agree, I'll open an issue in it repo and show this pain points to my teammates tomorrow |
I will try to fix the job tomorrow. |
By default das-cli requirements are not installed.
When das-cli is installed in standalone mode some libraries are not copied (for example common.config).
2fd09fe
to
527084b
Compare
@arturgontijo do you have an idea why Redis doesn't start on macos images https://github.com/vsbogd/hyperon-experimental/actions/runs/17229876711/job/48881457666 or may be how to get the reason from |
I afraid the reason is |
Yeah, that's right...I see a possible way to expose Docker would be adding this step before
Sorry for all these confusions, we definitely need to improve our tools and docs |
Looks like Docker is not supported by |
Yesterday I spent a lot trying to do this in singnet/das-toolbox#214 but still only able to properly install I have a very little xp with Actions so maybe I'm missing things...I'll talk to Levi (our devops) today to try to fix that. Other than that I think the best way would be having the C++ build binaries ready in a release for the most common platforms, I'll also discuss that with the team.
Yep, I use a macos 15 here and Docker works fine, so I can use My suggestion would be running this only on linux runners (+ |
Yeah, it looks like support for Docker in macos and linux Github images is not complete. Windows images has Docker preinstalled but doesn't have buildX and
Well to me it is an open question. At the moment I think that testing DAS integration on all platforms available is not a task for hyperon-experimental repo. It is a DAS team task. And if Python das-cli works on real hardware then there is nothing to bother about. Adding a smoke test for linux platform in hyperon-experimental should be enough. |
At the moment it is not possible to run Docker Buildx (which is required by das-cli) on macos- and windows- GitHub actions images. On the other hand testing DAS integration comprehensively is not a task of hyperon-experimental repo. It is suggested to keep only job to make a smoketest on linux. Be able run this job manually and as a part of nightly run.
@arturgontijo please review changes suggested by this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Allow passing Python environment version. Fix
das-cli
setup to use this version and virtual environment.@arturgontijo I have some questions about it:
python3 -m pip install -r requirements.txt
) (see https://github.com/vsbogd/hyperon-experimental/actions/runs/17214573397/job/48834855776) but one would expectpython3 -m pip install .
should be enough.common.yml
with "run-das-tests" flag.