Skip to content

Rewrite LiveTranslationFeature to TCA #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Sep 11, 2025
+684 −465
Merged

Rewrite LiveTranslationFeature to TCA #97

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
d147bda
♻️ rename LiveTranslationView and create LiveTranslation
touyou Apr 9, 2025
c93c972
♻️ almost all implementation without handleResponseChat and handleRes…
touyou Apr 9, 2025
c4de342
🎉 complete state and action reducer
touyou Apr 10, 2025
9b4bcc0
♻️ try to replace TCA version
touyou Apr 10, 2025
3bef97c
🚧 remove old files
touyou Apr 10, 2025
60b3932
🐛 fix translation bug
touyou Apr 10, 2025
c8e1825
✨ add reload button
touyou Apr 10, 2025
29e81b8
♻️ format
touyou Apr 10, 2025
a278d0d
add #91 changes
touyou Apr 11, 2025
b2329c2
Merge branch 'main' into refact/live-translation-tca
touyou Apr 11, 2025
88ea112
resolved package
touyou Apr 11, 2025
b32d9b4
♻️ rewrite send action to call function
touyou Apr 14, 2025
7d53241
♻️ use liveValue directly
touyou Apr 15, 2025
cf9000e
♻️ implement BuildConfig
touyou Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions MyLibrary/Package.resolved
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 9 additions & 1 deletion MyLibrary/Sources/AppFeature/AppView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ public struct AppReducer {
@ObservableState
public struct State: Equatable {
var schedule = Schedule.State()
var liveTranslation = LiveTranslation.State(
roomNumber: ProcessInfo.processInfo.environment["LIVE_TRANSLATION_KEY"]
?? (Bundle.main.infoDictionary?["Live translation room number"] as? String) ?? ""
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extract to BulidConfig, which defined as Dependency Client.
See how it works at isowords:

https://github.com/pointfreeco/isowords/tree/main/Sources/Build

Build is preserved in .gitignore so use BuildConfig instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@d-date I tried to write it on cf9000e.

var guidance = Guidance.State()
var sponsors = SponsorsList.State()
var trySwift = TrySwift.State()
Expand All @@ -24,6 +28,7 @@ public struct AppReducer {

public enum Action {
case schedule(Schedule.Action)
case liveTranslation(LiveTranslation.Action)
case guidance(Guidance.Action)
case sponsors(SponsorsList.Action)
case trySwift(TrySwift.Action)
Expand All @@ -35,6 +40,9 @@ public struct AppReducer {
Scope(state: \.schedule, action: \.schedule) {
Schedule()
}
Scope(state: \.liveTranslation, action: \.liveTranslation) {
LiveTranslation()
}
Scope(state: \.guidance, action: \.guidance) {
Guidance()
}
Expand All @@ -60,7 +68,7 @@ public struct AppView: View {
.tabItem {
Label(String(localized: "Schedule", bundle: .module), systemImage: "calendar")
}
LiveTranslationView()
LiveTranslationView(store: store.scope(state: \.liveTranslation, action: \.liveTranslation))
.tabItem {
Label(String(localized: "Translation", bundle: .module), systemImage: "text.bubble")
}
Expand Down
Loading