Skip to content

chore: pin rx4 to rotary harness SHA - #74

Open
undivisible wants to merge 1 commit into
mainfrom
feat/rx4-harness-pin
Open

chore: pin rx4 to rotary harness SHA#74
undivisible wants to merge 1 commit into
mainfrom
feat/rx4-harness-pin

Conversation

@undivisible

@undivisible undivisible commented Aug 23, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Pin rx4 to tschk/rotary @ 441ce524ef8b3ec2372227ba35b91fad0bc4389a (feat/rx4-agent-harness), keeping default-features = false and the existing feature set (ipc, providers, skills, graph-memory).

Test plan

  • cargo check (git dep already fetched)
  • Confirm apollo still builds against hashline/prewalk exports if used

Note

Medium Risk
Swaps the core agent-loop dependency to an unreleased git SHA, so apollo can pick up harness API/behavior changes without a crates.io release. No application code is changed in this PR.

Overview
Pins the rx4 agent-harness crate to tschk/rotary at 441ce524 instead of crates.io 0.6.4. Feature flags stay the same (ipc, providers, skills, graph-memory; default features off).

Cargo.lock follows that git dep (reported as 0.6.5) and the usual transitive Windows/base64/getrandom version shifts.

Reviewed by Cursor Bugbot for commit 7bbb033. Configure here.

@cursor

cursor Bot commented Aug 23, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_2f9989f6-6f8b-46f3-ba84-ce20efdeecb0)

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7bbb0337fe

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Cargo.toml
# pulls in the fff/git2/notify stack), `mcp` (apollo has src/mcp_server.rs),
# `zkr-memory` (gates rx4's self_improve; apollo depends on zkr directly).
rx4 = { version = "0.6.4", default-features = false, features = ["ipc", "providers", "skills", "graph-memory"] }
rx4 = { git = "https://github.com/tschk/rotary.git", rev = "441ce524ef8b3ec2372227ba35b91fad0bc4389a", default-features = false, features = ["ipc", "providers", "skills", "graph-memory"] }

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep a registry version alongside the pinned revision

When preparing the repository's advertised crates.io package, Cargo rejects this manifest because every published dependency must specify a version requirement; cargo package reports that the git specification is removed from the packaged manifest. Since this entry now has only git and rev, the next crates.io release is blocked before compilation. Retain version = "0.6.5" alongside the git pin so local builds use the revision while the packaged crate resolves rx4 from crates.io.

AGENTS.md reference: AGENTS.md:L40-L42

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant