fix(process): argv spawn docs and short preview sockets - #273
Merged
Conversation
#267 did not close a shell-injection hole; process_run already uses Command::new. Lock that split in tests and keep macOS unix-socket tests under sun_path. Co-authored-by: Cursor <cursoragent@cursor.com>
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_90d6515a-f758-4dcb-8a1d-7fab516c526b) |
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#267wrappedprocess_runinguard_command, which only records owned-native invocations. Spawn was alreadyCommand::new+ argv (no/bin/sh -c). This corrects the leftover "shell one-liner" docs and tests that;,&&,$(), and backticks stay extra argv tokens.#265Unix-socket test paths so macOSsun_path(103 bytes) is not exceeded in CI temp dirs.Test plan
cargo test --manifest-path in-cli/Cargo.toml --lib -- test_parse_command_args test_run_unix_preview_clientMade with Cursor