Skip to content

Make building own libsamplerate and pybind11 optional #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

uis246
Copy link

@uis246 uis246 commented Feb 12, 2025

No description provided.

@uis246
Copy link
Author

uis246 commented Feb 12, 2025

Fixes #24

Currently it does not check if libsamplerate is installed. It has to be done with pkgconf, I think.

@fakufaku fakufaku self-requested a review February 15, 2025 14:40
@fakufaku
Copy link
Collaborator

Hi @uis246 , thanks for the contribution.

While it is nice to have the option to use the local libraries, you set the default to ON, which means the install now fails on all systems that do not have it. Libsamplerate is not such a popular library, so keeping the option to OFF is a better default I think.
Could you please make the modification?

As an improvement, would it be possible to fall back to OFF (not using local libraries) if the library cannot be found? I suppose that cmake should have such a mechanism, but I am not an expert myself.

Copy link
Collaborator

@fakufaku fakufaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current CI tests only check the static linking of libsamplerate.
Would it be possible for you to write a CI test for your option?

@uis246
Copy link
Author

uis246 commented Feb 17, 2025

Would it be possible for you to write a CI test for your option?

Not sure how and not sure what exactly it should test.

@uis246 uis246 requested a review from fakufaku February 17, 2025 23:52
@fakufaku
Copy link
Collaborator

Sorry I was so slow to come back to this.
You could add a section in the CI where you install the external libsamplerate library and then compile with the option set to OFF.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants