Improve typing of django.db.backends.mysql.base.DatabaseWrapper attributes
#2125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
reviewed
May 5, 2024
intgr
changed the title
Any value for django.db.backends.mysql.base.DatabaseWrapper's argumentsdjango.db.backends.mysql.base.DatabaseWrapper attributes
intgr
reviewed
May 6, 2024
sobolevn
reviewed
May 12, 2024
| django_conversions: Any | ||
| server_version_re: Any | ||
|
|
||
| class MySQLDatabase(Protocol): ... |
There was a problem hiding this comment.
This protocol should have at least some attributes / methods
There was a problem hiding this comment.
I'm having a hard time figuring it out. I think I just need to add methods or attributes related to the connection, but is there anything else I can include?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
I modified the
Anyvalue of thedjango.db.backends.mysql.base.DatabaseWrapper's arguments .django.db.backends.mysql.base.DatabaseWrapper.data_typesdjango.db.backends.mysql.base.DatabaseWrapper.operatorsdjango.db.backends.mysql.base.DatabaseWrapper.pattern_opsdjango.db.backends.mysql.base.DatabaseWrapper.isolation_levelsdjango.db.backends.mysql.base.DatabaseWrapper.SchemaEditorClassdjango.db.backends.mysql.base.DatabaseWrapper.isolation_leveldjango.db.backends.mysql.base.DatabaseWrapper.needs_rollbackRelated issues