Skip to content

Narrow RegexValidator.regex instance level type to Pattern[str] #2650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

Narrow RegexValidator.regex instance level type to Pattern[str] #2650

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
03f7ea8
Narrow `REgexValidator.regex` type because it cast to a pattern in init
UnknownPlatypus May 2, 2025
d7f9a54
Use a descriptor to describe the type
UnknownPlatypus May 2, 2025
e86f563
Fix after CR
UnknownPlatypus May 2, 2025
4647a3e
Amend the allowlist
UnknownPlatypus May 2, 2025
af7948e
Add pyright ignores too + use `typing_extensions`
UnknownPlatypus May 2, 2025
ec1a145
Add missing pyright ignores
UnknownPlatypus May 2, 2025
0ca8419
Add test cases
UnknownPlatypus May 3, 2025
31b6939
Remove descriptor approach, It doesn't handle subclassing well
UnknownPlatypus May 3, 2025
1d4eff0
Correct pyright ignore
UnknownPlatypus May 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion django-stubs/core/validators.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ _Regex: TypeAlias = str | Pattern[str]
_ValidatorCallable: TypeAlias = Callable[[Any], None] # noqa: PYI047

class RegexValidator(_Deconstructible):
regex: _Regex # Pattern[str] on instance, but may be str on class definition
regex: Pattern[str]
message: _StrOrPromise
code: str
inverse_match: bool
Expand Down
Loading