Skip to content

[Breaking change] Remove work-around for ModelSerializer.instance field for many=True #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 18, 2025
Merged

[Breaking change] Remove work-around for ModelSerializer.instance field for many=True #719

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b6d0b8a
fix: model serializer instance should not be sequence
JoshFerge Jan 13, 2025
db0e111
remove type ignore
JoshFerge Jan 13, 2025
0229c10
Merge branch 'master' into jferg/fix-type
JoshFerge Jan 22, 2025
63405dc
Update serializers.pyi
JoshFerge Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rest_framework-stubs/serializers.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ class ModelSerializer(Serializer[_MT]):
serializer_url_field: type[RelatedField]
serializer_choice_field: type[Field]
url_field_name: str | None
instance: _MT | Sequence[_MT] | None # type: ignore[assignment]
instance: _MT | None # type: ignore[assignment]

class Meta:
model: type[_MT] # type: ignore
Expand Down
Loading