Skip to content

Add variation selectors to symbols that exist in both sym and emoji #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MDLC01
Copy link
Collaborator

@MDLC01 MDLC01 commented Jul 16, 2025

This PR fixes #21, fixes #23, and closes #25, by adding the appropriate variation selectors to symbols that exist in both sym and emoji. I verified that all the variation sequences are defined in by Unicode.12

I have marked this PR as a draft because the next step is to add variation selectors to all symbols that allow it, whether present in both sym and emoji or not, to prevent ambiguity.

This made me realize that some emojis are poorly named, but improving this is a task for a separate PR.

Related: typst/typst#6489 (comment).

Footnotes

  1. https://www.unicode.org/reports/tr51/#Emoji_Variation_Sequences

  2. https://www.unicode.org/Public/UCD/latest/ucd/emoji/emoji-variation-sequences.txt

@Enivex
Copy link
Collaborator

Enivex commented Jul 17, 2025

This made me realize that some emojis are poorly named,

It's a lot of them. My recentish pr only covered a small part.

@T0mstone
Copy link
Collaborator

I'll be the first to bring up automation here:
Whether we want to automate this in the future or not, I think we should definitely have all of these hard-coded in the source code, since such automation would probably take a lot of time that we shouldn't have to pay on each build.
The automation would then only be an optional verification step like in #9. (And maybe we always enable it in CI)

That means any concerns about such automation should not block this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants