-
-
Notifications
You must be signed in to change notification settings - Fork 12
Add playing cards #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Enivex
commented
May 22, 2025
- One possibility is moving the suit symbols into this, but that would be a breaking change.
- I considered using roman numerals for the the numbering of the trump cards. However, we've just spelled out numbers elsewhere, so I did that for consistency.
- Each tarot card also has a meaning (https://en.wikipedia.org/wiki/Bourgeois_Tarot#Tarot_Nouveau) which could possibly be an alias, but I'm not sure if it's worth it.
|
Hm, it's failing because of the text variation selector on Should I
? |
|
Also: Is |
I'd advocate for waiting on #25 |
For the record, I think |
|
It's a bit long, but presumably anyone using this would import the submodule anyway. |
|
Closing until the multi-character symbols situation is resolved. |
|
Reopening since the multi-character symbols situation has been resolved a while ago. |
T0mstone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changelog needs to be updated now too (cf. #121 (review)).