Skip to content

Conversation

@Enivex
Copy link
Collaborator

@Enivex Enivex commented May 22, 2025

  • One possibility is moving the suit symbols into this, but that would be a breaking change.
  • I considered using roman numerals for the the numbering of the trump cards. However, we've just spelled out numbers elsewhere, so I did that for consistency.
  • Each tarot card also has a meaning (https://en.wikipedia.org/wiki/Bourgeois_Tarot#Tarot_Nouveau) which could possibly be an alias, but I'm not sure if it's worth it.

@Enivex
Copy link
Collaborator Author

Enivex commented May 22, 2025

Hm, it's failing because of the text variation selector on card.joker.black.

Should I

  • Remove the variation selector
  • Remove the black joker for the time being
  • Wait until variation selectors are supported

?

@Enivex
Copy link
Collaborator Author

Enivex commented May 22, 2025

Also: Is card too generic? I couldn't think of another option not involving having to use a hyphen (which we've avoided so far)

@T0mstone
Copy link
Collaborator

Should I

  • Remove the variation selector

  • Remove the black joker for the time being

  • Wait until variation selectors are supported

I'd advocate for waiting on #25

@Enivex Enivex added the multi-character symbols This requires multi-code point symbols label May 22, 2025
@T0mstone
Copy link
Collaborator

Also: Is card too generic? I couldn't think of another option not involving having to use a hyphen (which we've avoided so far)

For the record, I think playingcard without any separator would be fine too.

@Enivex
Copy link
Collaborator Author

Enivex commented May 24, 2025

It's a bit long, but presumably anyone using this would import the submodule anyway.

@Enivex Enivex changed the title Add playing cards submodule Add playing cards May 24, 2025
@Enivex Enivex added the blocked This is blocked by something label Jun 13, 2025
@Enivex
Copy link
Collaborator Author

Enivex commented Jun 20, 2025

Closing until the multi-character symbols situation is resolved.

@Enivex Enivex closed this Jun 20, 2025
@T0mstone
Copy link
Collaborator

Reopening since the multi-character symbols situation has been resolved a while ago.

@T0mstone T0mstone reopened this Oct 14, 2025
@T0mstone T0mstone removed the blocked This is blocked by something label Oct 14, 2025
Copy link
Collaborator

@T0mstone T0mstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog needs to be updated now too (cf. #121 (review)).

@MDLC01 MDLC01 added the waiting on author This is waiting on an action by the author label Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

multi-character symbols This requires multi-code point symbols waiting on author This is waiting on an action by the author

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants