-
Notifications
You must be signed in to change notification settings - Fork 630
bellbird-udesc-paper:0.0.1 #2744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
bellbird-udesc-paper:0.0.1 #2744
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, thank you! Just two small remarks:
- However, the font must also be **installed on your operating system** to render correctly. | ||
- On Windows, these fonts are typically pre-installed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only true when running Typst outside of the web app, I think it needs to be stated more explicitly. Also, it is possible to not install the fonts globally and to use --font-path
, it may be worth mentioning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. I add a mention of that flag and improve the text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the logo are copyrighted and/or under a specific license, can you please specify it (at the end of your README for instance).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I replaced it with a photograph under a Creative Commons license.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should still be specified somewhere, as this is not the same license as the rest of your package. Also, if it has the BY clause, you should cite its author.
Kebab-cases in all fields and variables now. Thank you for the corrections. |
Thanks! Once you will have added license information for the photograph you added I think we can merge :) |
I am submitting
Description: Explain what the package does and why it's useful.
I have read and followed the submission guidelines and, in particular, I
typst.toml
file with all required keysREADME.md
with documentation for my packageLICENSE
file or linked one in myREADME.md
exclude
d PDFs or README images, if any, but not the LICENSE