-
Notifications
You must be signed in to change notification settings - Fork 154
Unify package and archive modes #273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify package and archive modes #273
Conversation
cc @JamyDev |
Seems sane to me. Tagging @sywhang for review. |
fd4fd0f
to
030b99f
Compare
@sywhang @linzhp Could you please review this PR? I have two commits to simplify review
|
030b99f
to
f142e57
Compare
Hey folks, is there a chance to get this PR merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR, and sorry for the delay in response. The Uber Go team is fairly occupied lately so we've got a bit of catch up reviews to do.
Just took a look at this PR and it looks good, but there are some behavioral changes in archive mode that's being "fixed" as a result of the code merging that might be worth adding to CHANGELOG:
- we now error out on type constraints in archive mode.
- we now handle type aliases explicitly in archive mode.
Feel free to modify CHANGELOG, otherwise I plan on merging this tomorrow morning and will be adding these ourselves later before releasing.
f142e57
to
9098d3b
Compare
No worries, thank you for the review. I've added information about this change to the CHANGELOG. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
package
andarchive
modes (thepackage
parsing implementation)archive
parsing implementation added in Support for archive mode #258Bump(already landed update golang.org/x/tools to v0.36.0 #276)golang.org/x/tools
to v0.26.0 to support archives v2 and unblock go1.25 supportCloses #272