Skip to content

fix popup #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix popup #557

wants to merge 1 commit into from

Conversation

@jeffhuangt
Copy link
Contributor

@jeffhuangt jeffhuangt commented Mar 24, 2025

Overview

All Changes

  • Changed the color of the announcement button
  • Made the popup scrollable if it gets too big
  • Disabled the popup on mobile

jamesmwu
jamesmwu approved these changes Mar 31, 2025
View reviewed changes
Copy link
Collaborator

@jamesmwu jamesmwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jamesmwu jamesmwu jamesmwu approved these changes

@Nishant-Ray Nishant-Ray Awaiting requested review from Nishant-Ray

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jeffhuangt @jamesmwu