This repository was archived by the owner on Jun 28, 2022. It is now read-only.
updated removeContact method #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update removeContact
lukasz81
reviewed
Sep 11, 2017
src/App.js
Outdated
| })) | ||
|
|
||
| ContactsAPI.remove(contact) | ||
| ContactsAPI.create(contact).then(contact => { |
There was a problem hiding this comment.
Should it not be remove method ?
ContactsAPI.remove(contact).then( contact => { this.setState(state => ({ contacts: state.contacts.filter(c => c.id !== contact.id) })) })
lukasz81
approved these changes
Sep 21, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the contact only when the backend sends a success in its promise.