Skip to content

Update logging with new abstraction/configuration #7271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

Migaroez
Copy link
Contributor

@Migaroez Migaroez commented Jul 29, 2025

📋 Description

Updates the documentation regarding the default umbraco logging

  • Adds a description around the UmbracoFile Sink
  • Updates json config with new Enabled setting
  • Explains the setting below the json file
  • Replaces code example regarding custom logviewer with new example using ILogVieverRepository, the old code is no longer consumed by the client.

✅ Contributor Checklist

I've followed the Umbraco Documentation Style Guide and can confirm that:

  • Code blocks are correctly formatted.
  • Sentences are short and clear (preferably under 25 words).
  • Passive voice and first-person language (“we”, “I”) are avoided.
  • Relevant pages are linked.
  • All links work and point to the correct resources.
  • Screenshots or diagrams are included if useful.
  • Any code examples or instructions have been tested.
  • Typos, broken links, and broken images are fixed.

Product & Version (if relevant)

CMS 16.2

Deadline (if relevant)

When the following PR is merged in and the linked version is released
umbraco/Umbraco-CMS#19818

This is expected on 21st August to coincide with the 16.2 release candidate release.

AndyButland
AndyButland previously approved these changes Jul 30, 2025
Copy link
Contributor

@AndyButland AndyButland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of suggestions for typos and shorter sentences.

Looks good to me, but as per comment, I wonder if we need to also document a need to also provide an ILoggerService implementation too?

@AndyButland AndyButland dismissed their stale review July 30, 2025 04:57

Removing approval as realised more work is needed.

@sofietoft
Copy link
Contributor

Hi @Migaroez

Is it correct, that this is for Umbraco 14? That version is no longer supported and considered EOL, right? 🤔

@Migaroez
Copy link
Contributor Author

Hi @Migaroez

Is it correct, that this is for Umbraco 14? That version is no longer supported and considered EOL, right? 🤔

Oops sorry, that was a mistake in the description.

@AndyButland AndyButland self-requested a review August 1, 2025 09:30
Copy link
Contributor

@AndyButland AndyButland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made the updates raised in my first review and aligned with the latest code, that is now merged in and scheduled for 16.2.

As such approving this, so it's ready for docs team review and can be merged and published along with the release of the 16.2 release candidate (due 21st August).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants