-
Notifications
You must be signed in to change notification settings - Fork 802
Update logging with new abstraction/configuration #7271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of suggestions for typos and shorter sentences.
Looks good to me, but as per comment, I wonder if we need to also document a need to also provide an ILoggerService
implementation too?
Removing approval as realised more work is needed.
Hi @Migaroez Is it correct, that this is for Umbraco 14? That version is no longer supported and considered EOL, right? 🤔 |
Oops sorry, that was a mistake in the description. |
Co-authored-by: Andy Butland <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made the updates raised in my first review and aligned with the latest code, that is now merged in and scheduled for 16.2.
As such approving this, so it's ready for docs team review and can be merged and published along with the release of the 16.2 release candidate (due 21st August).
📋 Description
Updates the documentation regarding the default umbraco logging
✅ Contributor Checklist
I've followed the Umbraco Documentation Style Guide and can confirm that:
Product & Version (if relevant)
CMS 16.2
Deadline (if relevant)
When the following PR is merged in and the linked version is released
umbraco/Umbraco-CMS#19818
This is expected on 21st August to coincide with the 16.2 release candidate release.