feat(ToDo): Add Desktop Target #892
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…0 InitializeLogging call Test Build succeeded, limitations in app given through known issues
There was a problem hiding this comment.
Pull Request Overview
This PR adds desktop target support to the ToDo sample application by upgrading the Uno.Sdk version and configuring desktop platform settings. The changes enable the ToDo app to run on desktop environments (Linux via X11) alongside existing mobile and web targets.
Key Changes
- Upgrade Uno.Sdk from 6.0.67 to 6.1.23
- Add
net9.0-desktoptarget framework to enable desktop platform support - Remove deprecated
App.InitializeLogging()call from desktop Program.cs
Reviewed Changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| global.json | Updates Uno.Sdk version to 6.1.23 and removes outdated comment |
| ToDo.csproj | Adds net9.0-desktop to target frameworks list |
| Properties/launchSettings.json | Adds desktop and WSL2 launch profiles for desktop development |
| Platforms/Desktop/Program.cs | Removes deprecated InitializeLogging call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Build succeeded, limitations in app given through known issues
GitHub Issue: closes #
PR Type:
What is the current behavior? 🤔
ToDo app is not having a desktop target
What is the new behavior? 🚀
app.InitializeLogging()call in Programm.cs like on my own apps after the 6.0 sdk upgradePR Checklist ✅
Please check if your PR fulfills the following requirements:
📝 Commits must be following the Conventional Commits specification.
🧪 Added Runtime tests, UI tests, or a manual test sample for the changes have been added (for bug fixes / features) (if applicable)
📚 Docs have been added/updated which fit documentation template (for bug fixes / features)
🖼️ Validated PR
Screenshots Compare Test Runresults.❗ Contains NO breaking changes (not added to Rider or vs code folders if that matters)
Other information ℹ️
Possibly the #887 can be updated accordingly for the ToDo app?
as no new templated uno app has the Win10 sdk in the Directory.Build.props maybe that should get removed, so new users checking out the templates would not get annoyed from having to downgrade or additionally install packages they do not need in new uno apps...