Skip to content

Upgrade Upject to v1.5.0 #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Upgrade Upject to v1.5.0 #22

wants to merge 7 commits into from

Conversation

khalilj
Copy link

@khalilj khalilj commented Feb 13, 2025 •
edited
Loading

Description of your changes

Upject needs to get upgraded to v1.5.0 to get MR Metrics

Fixes #21

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Running the provider locally.

@khalilj
Copy link
Author

khalilj commented Feb 17, 2025

@sergenyalcin @ulucinar can you help with CI failures?
When running the provider locally against my cluster, i still don't get the metrics:

crossplane_managed_resource_exists
crossplane_managed_resource_ready
crossplane_managed_resource_synced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ulucinar ulucinar Awaiting requested review from ulucinar ulucinar is a code owner

@sergenyalcin sergenyalcin Awaiting requested review from sergenyalcin sergenyalcin is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing Expected Metrics: crossplane_managed_resource_exists, crossplane_managed_resource_ready, crossplane_managed_resource_synced

2 participants

@khalilj @khalilj-appsflyer