Skip to content

update node-machine-id to @usebruno/node-machine-id - #2661

Merged
helloanoop merged 4 commits into
usebruno:mainfrom
lohxt1:feat/bruno-node-machine-id
Jul 18, 2024
Merged

helloanoop merged 4 commits into
usebruno:mainfrom
lohxt1:feat/bruno-node-machine-id

Conversation

@lohxt1

@lohxt1 lohxt1 commented Jul 18, 2024 •

Copy link
Copy Markdown
Contributor

Description

to use the forked version of node-machine-id, which includes a fix for the issue where the machine ID can't be accessed on Windows systems with registry editing disabled.

ref issue: automation-stack/node-machine-id#56
ref pr: automation-stack/node-machine-id#57

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

@helloanoop
helloanoop merged commit 7194998 into usebruno:main Jul 18, 2024
maxenceleblanc pushed a commit to maxenceleblanc/curly_cats2 that referenced this pull request Jul 20, 2026
* update node-machine-id to @usebruno/node-machine-id

* added lock file

* tests check

* tests check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants