Fix different column for nulls bug in create documents#524
Merged
Conversation
abnegate
reviewed
Feb 12, 2025
Merged
# Conflicts: # src/Database/Adapter/MariaDB.php # src/Database/Adapter/Postgres.php
abnegate
reviewed
Feb 12, 2025
abnegate
reviewed
Feb 12, 2025
abnegate
approved these changes
Feb 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create documents constructs the column list based on all documents however there is a chance that values don't exist on a document (because of it not being required) meaning it doesn't get set in the bindValues resulting in a diff between the number of values expected and the number of values given.
This PR fixes that by making a column list of all the documents and checking against that when binding values, if a value doesn't exist it will be set as null within the bindValues. Validators from the database adapter should catch if a value is required or doesn't exist at all so we don't need to check that.
Tests have been added to make sure that this fixes the bug explained.