Skip to content

Conversation

@web-padawan
Copy link

@web-padawan web-padawan commented Oct 24, 2025

WIP, do not merge.

Depends on #12

This is a PR for the actual V25 upgrade. There are still some more things to do:

Done

  • Replaced custom overlay implementation with vaadin-popover wrapping calendar
    • This provides out of the box styling and significantly simplifies component theming
  • Moved button elements from vcf-month-picker-calendar shadow DOM to slots
    • Both use vaadin-button with theme="vcf-month-picker" for easier styling
    • Needed to ensure that global Aura CSS applies to these buttons if necessary
  • Moved year label to the slot as well, to make aria-labelledby ID reference work
  • Added part attributes to month grid and cells in vcf-month-picker-calendar

TODO

  • Remove remaining Lumo styles from JS files (src / theme) and add a CSS file instead
  • Add some base styles tweaks e.g to make toggle button look correctly with base styles

@web-padawan web-padawan force-pushed the refactor/v25-overlay-replace branch from 5c133f0 to a590bbf Compare October 25, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant