Fix CD pipeline. #38
Open
Fix CD pipeline. #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
had a problem deploying
to
Release
GitHub Actions
Failure
Yury-Fridlyand
had a problem deploying
to
Release
GitHub Actions
Failure
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
had a problem deploying
to
Release
GitHub Actions
Failure
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
had a problem deploying
to
Release
GitHub Actions
Failure
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
had a problem deploying
to
Release
GitHub Actions
Failure
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
had a problem deploying
to
Release
GitHub Actions
Failure
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
had a problem deploying
to
Release
GitHub Actions
Failure
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
yipin-chen
approved these changes
Aug 21, 2025
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
jamesx-improving
approved these changes
Aug 22, 2025
| @@ -91,7 +91,6 @@ jobs: | |||
| os: ${{ matrix.host.OS }} | |||
| target: ${{ matrix.host.TARGET }} | |||
| github-token: ${{ secrets.GITHUB_TOKEN }} | |||
| engine-version: ${{ matrix.engine.version }} | |||
There was a problem hiding this comment.
I see that the corresponding input name on this repo has been changed to server-version. But if it is intentional to skip the installation of valkey-server in this job (as there's an if-condition on the Install server step of install-shared-dependencies) then its fine.
There was a problem hiding this comment.
It does should not install the server if input is not given
|
|
||
| build-package-to-publish: | ||
| needs: [set-release-version, create-binaries] | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| RELEASE_VERSION: ${{ needs.set-release-version.outputs.RELEASE_VERSION }} | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/checkout@v5 |
There was a problem hiding this comment.
Do we need with: submodules: true here?
There was a problem hiding this comment.
No, this step builds dotnet code only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/valkey-io/valkey-glide-csharp/actions/runs/17132293727 which published
0.1.0-rc8