Skip to content

Conversation

phiro56
Copy link
Contributor

@phiro56 phiro56 commented Jul 4, 2025

feat: Add GitHub button to navigation bar

Screenshot 2025-07-03 at 10 00 44 PM

Copy link
Member

@stockholmux stockholmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the look but it fails responsiveness between width of 917px and the breakpoint at 768px, so the menu bar gets eaten off the right side (also affects "Try Valkey" item)

Screenshot 2025-07-11 at 7 57 31 AM Screenshot 2025-07-11 at 7 56 14 AM

@phiro56
Copy link
Contributor Author

phiro56 commented Jul 11, 2025

@stockholmux I've increase responsive view port of the main nav to 1024px...

phiro56 and others added 2 commits July 16, 2025 18:53
- Implement star count fetching from GitHub API

Signed-off-by: Daniel Phillips <[email protected]>
@phiro56
Copy link
Contributor Author

phiro56 commented Sep 10, 2025

@stockholmux requested changes added. See screenshot below.

Screenshot 2025-09-10 at 12 38 50 PM

@phiro56
Copy link
Contributor Author

phiro56 commented Sep 12, 2025

@stockholmux what do you think now?

Screenshot 2025-09-12 at 5 28 32 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants