Add blog post: Introduction to Valkey helm chart #408
Conversation
cherukum-Amazon
requested review from
madolson and
stockholmux
as code owners
stockholmux
left a comment
stockholmux
left a comment
There was a problem hiding this comment.
I like the blog! It has some usability issues with the code samples but they should be pretty easy to fix.
Otherwise, it's just little things that need attention. With the fixes, I think we can publish next week if you can get to the changes required ASAP.
|
|
||
| ## Next steps | ||
|
|
||
| This is the rough plan. We will keep the work visible in the repo at [https://github.com/valkey-io/valkey-helm](https://github.com/valkey-io/valkey-helm). |
There was a problem hiding this comment.
Why is this a rough plan? What does that mean?
Shorten the link to text to valkey-io/valkey-helm
There was a problem hiding this comment.
Change 'We will keep the work visible in the repo' to something like 'All development on this Helm chart occurs in the open'.
(The future tense isn't correct in the original and I like to avoid conusing 'we' statements).
|
|
||
| This is the rough plan. We will keep the work visible in the repo at [https://github.com/valkey-io/valkey-helm](https://github.com/valkey-io/valkey-helm). | ||
|
|
||
| * **Cluster mode.** Make it easy to run primaries and replicas across slots with sane defaults. |
There was a problem hiding this comment.
Do any of these have links to issues?
| * **Upgrades.** Publish notes tied to Valkey releases. Add hooks and checks so failures are obvious and quick to revert. | ||
| * **Docs.** Keep them short. Add clear examples. Link to deeper guides only when needed. | ||
|
|
||
| If you currently rely on Bitnami, test this chart in a dev cluster and try your normal workflows. If something is missing, open an issue at [https://github.com/valkey-io/valkey-helm/issues](https://github.com/valkey-io/valkey-helm/issues). Once you try out the official Valkey helm chart please share feedback so the chart grows in the right direction. |
There was a problem hiding this comment.
change the link text to 'valkey-io/valkey-helm'
| * **Docs.** Keep them short. Add clear examples. Link to deeper guides only when needed. | ||
|
|
||
| If you currently rely on Bitnami, test this chart in a dev cluster and try your normal workflows. If something is missing, open an issue at [https://github.com/valkey-io/valkey-helm/issues](https://github.com/valkey-io/valkey-helm/issues). Once you try out the official Valkey helm chart please share feedback so the chart grows in the right direction. | ||
|
|
There was a problem hiding this comment.
ditch the extra lines at the end please
There was a problem hiding this comment.
something is wonky with the horizontal spacing. The plus sign is centred perfectly but the helm logo is far closer to the right side of the plus than the valkey logo is to the left side of the plus.
Also each blue is every so slightly different.
Signed-off-by: cherukum-amazon <[email protected]>
cherukum-Amazon
force-pushed
the
valkey-helm
branch
from
f26372d to
411403f
Compare
|
@cherukum-Amazon should we close this since #419 says it supersedes it? |
2 participants
Description
Description
This pull request adds a new blog post titled “Valkey Helm: The new way to deploy Valkey on Kubernetes”.
The blog explains why the Valkey project now provides an official Helm chart, summarizes recent Bitnami changes affecting users, and provides a detailed step-by-step migration guide for moving from Bitnami’s Valkey chart to the official Valkey chart.
The post includes:
This helps users adopt the official Helm chart safely and confidently.
Issues Resolved
This PR contributes toward addressing the community request for an official Helm chart and supporting documentation.
It provides the end-to-end migration guidance referenced in:
valkey-io/valkey#2371 (request for an official Helm chart)
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.