Skip to content

Conversation

@aradz44
Copy link
Contributor

@aradz44 aradz44 commented Jul 31, 2025

Creates reasonable limits:

  1. Max M reduce from 2M to 256.
  2. Query string depth default from 1000 to 16, Max is the same.
  3. Query string bytes max value from MAX_UINT to 10240.

Signed-off-by: Arad Zilberstein <[email protected]>
Copy link
Member

@allenss-amazon allenss-amazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, I believe the maximum values for these limits aren't properly set in this PR.

@zvi-code
Copy link
Collaborator

I mainly wanted to fix the M value, is that agreed? What would be the recommended limits in your opinion?

@allenss-amazon
Copy link
Member

For M, we know that M=1 causes a crash, so a minimum value for M of 2 avoids fixing the crash :)

As for maximum, I'm skeptical that there's any real usefulness above M=64 or 128, so any number that's close to that value is fine with me (512 or 1024 would be fine, but not like 2^20). But let's be clear, here I mean the maximum as the "default" value of configurable. The maximum value of configurable should be much higher, in case there's some odd-ball customer than needs M= to say 256 or 512.

@allenss-amazon
Copy link
Member

Can we update or close this PR?

@aradz44
Copy link
Contributor Author

aradz44 commented Oct 26, 2025

Closing it..

@aradz44 aradz44 closed this Oct 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants