Skip to content

Conversation

@adam-fowler
Copy link
Collaborator

@adam-fowler adam-fowler commented Jul 15, 2025

Include Swift CI soundness actions

  • Currently disabled license header and formatting as they require huge changes. Will do in later PR
  • Unacceptable language disabled as it clashes with some Valkey commands
  • Added environment variable to enable benchmarks in Package.swift as we can't install jemalloc for api-breakage test (not sure about this, makes local dev a little more annoying as we have to define ENABLE_VALKEY_BENCHMARKS to run the benchmarks). It currently fails because it can't compile main.

Looked at using the swift-nio unit-test setup but there doesn't seem to be anyway to run the integration tests if we use them.

Signed-off-by: Adam Fowler <[email protected]>
@github-actions
Copy link

github-actions bot commented Jul 15, 2025

✅ Pull request no significant performance differences ✅

Summary

New baseline 'pull_request' is WITHIN the 'main' baseline thresholds.

Full Benchmark Comparison

Comparing results between 'main' and 'pull_request'

Host '283612c5e561' with 4 'x86_64' processors with 15 GB memory, running:
#18~24.04.1-Ubuntu SMP Sat Jun 28 04:46:03 UTC 2025

ValkeyBenchmarks

GET benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 4 4 4 4 4 4 4 8
pull_request 4 4 4 4 4 4 4 9
Δ 0 0 0 0 0 0 0 1
Improvement % 0 0 0 0 0 0 0 1

HashSlot – {user}.whatever metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 0 0 0 0 0 0 0 18
pull_request 0 0 0 0 0 0 0 18
Δ 0 0 0 0 0 0 0 0
Improvement % 0 0 0 0 0 0 0 0

ValkeyCommandEncoder – Command with 7 words metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 0 0 0 0 0 0 0 752
pull_request 0 0 0 0 0 0 0 747
Δ 0 0 0 0 0 0 0 -5
Improvement % 0 0 0 0 0 0 0 -5

ValkeyCommandEncoder – Simple GET metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 0 0 0 0 0 0 0 1927
pull_request 0 0 0 0 0 0 0 1921
Δ 0 0 0 0 0 0 0 -6
Improvement % 0 0 0 0 0 0 0 -6

ValkeyCommandEncoder – Simple MGET 15 keys metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 0 0 0 0 0 0 0 360
pull_request 0 0 0 0 0 0 0 359
Δ 0 0 0 0 0 0 0 -1
Improvement % 0 0 0 0 0 0 0 -1

@adam-fowler adam-fowler requested a review from fabianfett July 15, 2025 10:12
@adam-fowler adam-fowler merged commit 4c650a7 into main Jul 15, 2025
12 of 13 checks passed
@adam-fowler adam-fowler deleted the swift-ci branch July 15, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants