Skip to content

Conversation

@eric-musliner
Copy link

This is dependent on the work to update the command json files in the ValkeySearch project valkey-io/valkey-search#504

 - Add generated Valkey Search commands from json doc files
 https://github.com/valkey-io/valkey-search/tree/main/src/commands

Signed-off-by: Eric Musliner <[email protected]>
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 98.59649% with 4 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@b813e95). Learn more about missing BASE report.

Files with missing lines Patch % Lines
Sources/ValkeySearch/SearchCommands.swift 98.59% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #263   +/-   ##
=======================================
  Coverage        ?   42.38%           
=======================================
  Files           ?       98           
  Lines           ?    12581           
  Branches        ?        0           
=======================================
  Hits            ?     5333           
  Misses          ?     7248           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@adam-fowler
Copy link
Collaborator

It's great you've added the updates to the spec files. I believe this'll also improve the documentation. I can't really merge this PR until the spec files PR is merged (and ideally in a release). We are near releasing a 1.0 and that will mean breaking changes can't be merged. We can workaround changes to the API caused by changes to the json spec files, but I don't really want to be doing this multiple times. We could hide these behind an "experimental-json-search" trait which we document as an API that may change.

@eric-musliner
Copy link
Author

It's great you've added the updates to the spec files. I believe this'll also improve the documentation. I can't really merge this PR until the spec files PR is merged (and ideally in a release). We are near releasing a 1.0 and that will mean breaking changes can't be merged. We can workaround changes to the API caused by changes to the json spec files, but I don't really want to be doing this multiple times. We could hide these behind an "experimental-json-search" trait which we document as an API that may change.

Completely understand. This PR is dependent on the JSON changes getting approved and merged in ValkeySearch. I definitely want eyes on that one to make sure it's correct and that I'm not missing anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants