Refactor of LFU/LRU code for modularity #2857
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jim Brunner <[email protected]>
ranshid
approved these changes
Nov 27, 2025
Member
ranshid
left a comment
ranshid
left a comment
There was a problem hiding this comment.
This is a great refactor @JimB123 !
I could not locate any special issues with the proposed change so gave some small comments. My only concern is that I am not sure how much our test coverage is great when it comes to eviction logic. I guess most of the tests are in maxmemory.tcl which are validated. I think that introducing it now (in early development stage) is probably fine.
| int objectSetLRUOrLFU(robj *val, long long lfu_freq, long long lru_idle_secs) { | ||
| if (lrulfu_isUsingLFU()) { | ||
| if (lfu_freq >= 0) { | ||
| serverAssert(lfu_freq <= 255); |
Member
There was a problem hiding this comment.
if we are refactoring...
Suggested change
| serverAssert(lfu_freq <= 255); | |
| serverAssert(lfu_freq <= UINT8_MAX); |
| } else { | ||
| val->lru = LRU_CLOCK(); | ||
| } | ||
| val->lru = lrulfu_touch(val->lru); |
Member
There was a problem hiding this comment.
why not wrap the touch as an Object API as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General cleanup on LRU/LFU code. Improve modularity and maintainability.
Specifically:
lrulfu.c, with an API inlrulfu.h. Knowledge of the LRU/LFU implementation was previously spread out acrossdb.c,evict.c,object.c,server.c, andserver.h.lrulfu.cknows about the LRU/LFU algorithms, without knowing about therobj.object.cknows about therobjwithout knowing about the details of the LRU/LFU algorithms.server.lruclock, instead usingserver.unixtime. This also eliminates the periodic need to callmstime()to maintain the lru clock.LFUTimeElapsedfunction (off by 1 after rollover).debug.cwhich would perform LFU modification on an LRU value.