Skip to content

fix(tsconfig.json): prevent duplicate tsconfig include entries on Windows #85056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from
+17 −7
Open

fix(tsconfig.json): prevent duplicate tsconfig include entries on Windows #85056

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions packages/next/src/lib/typescript/writeConfigurationDefaults.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import semver from 'next/dist/compiled/semver'
import os from 'os'
import type { CompilerOptions } from 'typescript'
import * as Log from '../../build/output/log'
import path from 'path'

type DesiredCompilerOptionsShape = {
[K in keyof CompilerOptions]:
Expand Down Expand Up @@ -267,25 +268,34 @@ export async function writeConfigurationDefaults(
}
}

const nextAppTypes: string[] = [`${distDir}/types/**/*.ts`]
// Normalize paths to POSIX style and dedupe to avoid duplicates on Windows
const toPosix = (p: string) => p.split(path.sep).join(path.posix.sep)

const nextAppTypes: string[] = [toPosix(`${distDir}/types/**/*.ts`)]

// When isolatedDevBuild is enabled, Next.js uses different distDir paths:
// - Development: "{distDir}/dev"
// - Production: "{distDir}"
// To prevent tsconfig updates when switching between dev/build modes,
// we proactively include both type paths regardless of current environment.
if (isolatedDevBuild !== false) {
nextAppTypes.push(
const extra =
process.env.NODE_ENV === 'development'
? // In dev, distDir is "{distDir}/dev", which is already in the array above, but we also need "{distDir}/types".
// Here we remove "/dev" at the end of distDir for consistency.
`${distDir.replace(/\/dev$/, '')}/types/**/*.ts`
toPosix(`${distDir.replace(/\/dev$/, '')}/types/**/*.ts`)
: // In build, distDir is "{distDir}", which is already in the array above, but we also need "{distDir}/dev/types".
// Here we add "/dev" at the end of distDir for consistency.
`${distDir}/dev/types/**/*.ts`
)
// Sort the array to ensure consistent order.
nextAppTypes.sort((a, b) => a.length - b.length)
toPosix(`${distDir}/dev/types/**/*.ts`)

nextAppTypes.push(extra)

// Dedupe and sort the array to ensure consistent order.
const deduped = Array.from(new Set(nextAppTypes))
deduped.sort((a, b) => a.length - b.length)
// replace contents
nextAppTypes.length = 0
nextAppTypes.push(...deduped)
}

if (!('include' in userTsConfig)) {
Expand Down
Loading