Skip to content

fix(deps): update dependency eslint to v9 - autoclosed #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(deps): update dependency eslint to v9 - autoclosed #718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"devDependencies": {
"@changesets/cli": "2.28.1",
"@vercel/style-guide": "5.2.0",
"eslint": "8.56.0",
"eslint": "9.38.0",
Copy link
Contributor

@vercel vercel bot Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Node.js engine constraint is incompatible with ESLint 9.38.0. ESLint 9 requires Node ^18.18.0 (or ^20.9.0 or >=21.1.0), but the project allows Node 18.0.0+.

View Details
📝 Patch Details 
diff --git a/package.json b/package.json
index 89bea95..8a97bc6 100644
--- a/package.json
+++ b/package.json
@@ -44,6 +44,6 @@
   },
   "packageManager": "[email protected]",
   "engines": {
-    "node": ">=18"
+    "node": "^18.18.0 || ^20.9.0 || >=21.1.0"
   }
 }

Analysis

Incorrect Node.js engine constraint allows incompatible versions with ESLint 9.38.0

What fails: Package.json specifies "engines": {"node": ">=18"}, which allows Node 18.0.0 through 18.17.x. However, ESLint 9.38.0 (listed in devDependencies) requires Node ^18.18.0 || ^20.9.0 || >=21.1.0 per ESLint's official documentation. Users installing on Node 18.0.0-18.17.x would pass the project constraint but fail when running ESLint.

How to reproduce:

  1. Check pnpm-lock.yaml: grep "[email protected]:" pnpm-lock.yaml -A 2 confirms engines: {node: ^18.18.0 || ^20.9.0 || >=21.1.0}
  2. Compare with package.json: Shows "node": ">=18" which has gap for Node 18.0.0-18.17.x

Result: Constraint mismatch exists - versions 18.0.0 through 18.17.x are allowed by project but rejected by ESLint 9.38.0

Expected: Engine constraint should align with ESLint 9's minimum version requirement to prevent installation on incompatible Node versions

Fix: Updated package.json engines field to "node": "^18.18.0 || ^20.9.0 || >=21.1.0" to match ESLint 9.38.0's documented requirement

"eslint-config-custom": "workspace:*",
"husky": "9.1.7",
"jest": "29.7.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/blob/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
"@types/async-retry": "1.4.9",
"@types/jest": "29.5.14",
"@types/node": "22.13.5",
"eslint": "8.56.0",
"eslint": "9.38.0",
"eslint-config-custom": "workspace:*",
"jest": "29.7.0",
"jest-environment-jsdom": "29.7.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/edge-config/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
"@edge-runtime/types": "2.2.9",
"@types/jest": "29.5.14",
"@types/node": "22.13.5",
"eslint": "8.56.0",
"eslint": "9.38.0",
"eslint-config-custom": "workspace:*",
"jest": "29.7.0",
"jest-fetch-mock": "3.0.3",
Expand Down
2 changes: 1 addition & 1 deletion packages/kv/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
"@edge-runtime/types": "2.2.9",
"@types/jest": "29.5.14",
"@types/node": "22.10.7",
"eslint": "8.56.0",
"eslint": "9.38.0",
"eslint-config-custom": "workspace:*",
"husky": "9.1.7",
"jest": "29.7.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/postgres-kysely/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
"@types/jest": "29.5.14",
"@types/node": "22.10.7",
"@types/ws": "8.5.13",
"eslint": "8.56.0",
"eslint": "9.38.0",
"eslint-config-custom": "workspace:*",
"jest": "29.7.0",
"kysely": "0.27.5",
Expand Down
2 changes: 1 addition & 1 deletion packages/postgres/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
"@types/jest": "29.5.14",
"@types/node": "22.10.7",
"@types/ws": "8.5.13",
"eslint": "8.56.0",
"eslint": "9.38.0",
"eslint-config-custom": "workspace:*",
"jest": "29.7.0",
"prettier": "3.4.2",
Expand Down
Loading
Loading