Worker: New Consumer class handling all possible producer stream modes.#1731
Draft
Worker: New Consumer class handling all possible producer stream modes.#1731
Conversation
New ProducerStreamManager interface with the following implementations: - SimpleProducerStreamManager: handles a single stream with no spatial or temporal layers. - SimulcastProducerStreamManager: handles N streams with 1 spatial and N temporal layers. - SvcProducerStreamManager: handles 1 stream with N spatial and M temporal layers. Consumer + SimpleProducerStreamManager replaces SimpleConsumer. Consumer + SimulcastProducerStreamManager replaces SimulcastConsumer. Consumer + SvcProducerStreamManager replaces SvcConsumer.
ibc
reviewed
Feb 16, 2026
ibc
reviewed
Feb 17, 2026
ibc
reviewed
Feb 17, 2026
Consumer::IsActive() checks: - transportConnected - paused - producerPaused - producerClosed ProducerStreamManager::IsActive() checks: - Consumer::IsActive() - Whether producer streams are active
ibc
previously requested changes
Feb 18, 2026
ibc
reviewed
Feb 18, 2026
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| this->listener->IsActive() && | ||
| std::any_of( | ||
| this->producerRtpStreams.begin(), | ||
| this->producerRtpStreams.end(), |
There was a problem hiding this comment.
warning: use a ranges version of this algorithm [modernize-use-ranges]
worker/src/RTC/SimulcastProducerStreamManager.cpp:4:
- #include "Logger.hpp"
+
+ #include <algorithm>
+ #include "Logger.hpp"
Suggested change
| this->producerRtpStreams.end(), | |
| std::ranges::any_of( | |
| this->producerRtpStreams, | |
| , |
| temporalLayer = 0; | ||
|
|
||
| // Check bitrate of every temporal layer. | ||
| for (; temporalLayer < producerRtpStream->GetTemporalLayers(); ++temporalLayer) |
There was a problem hiding this comment.
warning: comparison between 'signed' and 'unsigned' integers [modernize-use-integer-sign-comparison]
worker/src/RTC/SimulcastProducerStreamManager.cpp:4:
- #include "Logger.hpp"
+
+ #include <utility>
+ #include "Logger.hpp"
Suggested change
| for (; temporalLayer < producerRtpStream->GetTemporalLayers(); ++temporalLayer) | |
| for (; std::cmp_less(temporalLayer , producerRtpStream->GetTemporalLayers()); ++temporalLayer) |
| if (this->keyFrameForTsOffsetRequested) | ||
| { | ||
| // Give up and use the theoretical offset. | ||
| if (tsExtraOffset > maxTsExtraOffset) |
There was a problem hiding this comment.
warning: comparison between 'signed' and 'unsigned' integers [modernize-use-integer-sign-comparison]
Suggested change
| if (tsExtraOffset > maxTsExtraOffset) | |
| if (std::cmp_greater(tsExtraOffset , maxTsExtraOffset)) |
| tsExtraOffset = 1u; | ||
| } | ||
| } | ||
| else if (tsExtraOffset > maxTsExtraOffset) |
There was a problem hiding this comment.
warning: comparison between 'signed' and 'unsigned' integers [modernize-use-integer-sign-comparison]
Suggested change
| else if (tsExtraOffset > maxTsExtraOffset) | |
| else if (std::cmp_greater(tsExtraOffset , maxTsExtraOffset)) |
| int16_t spatialLayer{ 0 }; | ||
| int16_t temporalLayer{ 0 }; | ||
|
|
||
| for (; spatialLayer < this->producerRtpStream->GetSpatialLayers(); ++spatialLayer) |
There was a problem hiding this comment.
warning: comparison between 'signed' and 'unsigned' integers [modernize-use-integer-sign-comparison]
worker/src/RTC/SvcProducerStreamManager.cpp:4:
- #include "Logger.hpp"
+
+ #include <utility>
+ #include "Logger.hpp"
Suggested change
| for (; spatialLayer < this->producerRtpStream->GetSpatialLayers(); ++spatialLayer) | |
| for (; std::cmp_less(spatialLayer , this->producerRtpStream->GetSpatialLayers()); ++spatialLayer) |
| temporalLayer = 0; | ||
|
|
||
| // Check bitrate of every temporal layer. | ||
| for (; temporalLayer < this->producerRtpStream->GetTemporalLayers(); ++temporalLayer) |
There was a problem hiding this comment.
warning: comparison between 'signed' and 'unsigned' integers [modernize-use-integer-sign-comparison]
Suggested change
| for (; temporalLayer < this->producerRtpStream->GetTemporalLayers(); ++temporalLayer) | |
| for (; std::cmp_less(temporalLayer , this->producerRtpStream->GetTemporalLayers()); ++temporalLayer) |
| goto done; | ||
| } | ||
|
|
||
| for (; spatialLayer < this->producerRtpStream->GetSpatialLayers(); ++spatialLayer) |
There was a problem hiding this comment.
warning: comparison between 'signed' and 'unsigned' integers [modernize-use-integer-sign-comparison]
Suggested change
| for (; spatialLayer < this->producerRtpStream->GetSpatialLayers(); ++spatialLayer) | |
| for (; std::cmp_less(spatialLayer , this->producerRtpStream->GetSpatialLayers()); ++spatialLayer) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New
ProducerStreamManagerinterface with the following implementations:SimpleProducerStreamManager: handles a single stream with no spatial or temporal layers.SimulcastProducerStreamManager: handles N streams with 1 spatial and N temporal layers.SvcProducerStreamManager: handles 1 stream with N spatial and M temporal layers.This new class handles the different flavours of producers streams making
Consumeragnostic. This allows:Consumer + SimpleProducerStreamManagerreplacesSimpleConsumer.Consumer + SimulcastProducerStreamManagerreplacesSimulcastConsumer.Consumer + SvcProducerStreamManagerreplacesSvcConsumer.NOTE1: Old consumer has been named
OldConsumerfor the time being. Old consumers are deprecated and just left in the repo for comparison purposes while this PR is ongoing.NOTE2:
PipeConsumerhas not been touched as we are going to makeConsumerpipe-able and we'll not need any specific consumer implementation for that. Hence pipe consumer tests in NODE are failing. That's OK.NOTE3: This is a work in progress.
TODO: