Update API and IAMF Compatibility #50
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ral rendering, breaking from BEAR spec.
…efix 'C' from class names
…annels and layouts and to allow easier construction of default channels or layouts.
…s are ADM and which are more generic.
…rsion of the Binaural output of the AdmRenderer/Renderer class. Also removed HOA from the Layout class so it expects only layouts in OutputLayout
…fils the same purpose
…thout the need to use the Renderer class or metadata
…2094::channelLabels. Changed renaming to avoid incorrectly labelling LFER as LFE1
…ensure correct rendering
…runcation in pre-processing. Ensure that the input to Process() is not overwritten by the optimisation shelf filtering.
…ction as required for setting the positions.
… via the metadata. This already existed of Objects but has been added for HOA and DirectSpeaker streams. An overall gain can also be optionally applied to the output signal.
ePirat
reviewed
Oct 8, 2025
| /** Set a gain target that is to be applied to all channgels and the time in samples to interpolate to it. | ||
| * | ||
| * @param newGainVec Linear gain value to be applied to all channels. | ||
| * @param interpTimeInSamples The number of channels over which to interpolate to the new gain value. |
There was a problem hiding this comment.
Shouldn't this be "number of samples" and not channels?
ePirat
reviewed
Oct 8, 2025
| /** Set the gain vector target and the time in samples to interpolate to it. | ||
| * | ||
| * @param newGainVec Vector of new gains. Must have the same length as number of channels set in the constructor. | ||
| * @param interpTimeInSamples The number of channels over which to interpolate to the new gain vector. |
ePirat
reviewed
Oct 8, 2025
| ) | ||
|
|
||
| if(MYSOFA_FOUND) | ||
| message("Found mysofa!") |
There was a problem hiding this comment.
Seems this was accidentally included in the commit
There was a problem hiding this comment.
You should already be able to see if it found mysofa in the CMake log output btw:
-- Checking for module 'libmysofa'
-- Found libmysofa, version 1.3
. Before that commit the decoder coefficients in AmbisonicDecoder assumed N3D normalisation and correction for SN3D normalisation (used by the lib) was done at decoding. 1dc37eb moved the N3D->SN3D correction to the decoder coefficients. However, the old correction was left in AmbisonicBinauralizer, leading to double "correction". This commit also fixes a bug where the correction gain was not applied to the highest order channels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is an update that hopefully makes the API clearer and easier to use, as well as to make it more compatible with the IAMF specification. The main changes are:
Once we settle on these changes I still need to update the docs to reflect the API changes and to make it clearer what the lib can do :)