Skip to content

Allow passing in the title from state - #313

Open
mvhenten wants to merge 1 commit into
visionmedia:masterfrom
mvhenten:pass-in-title
Open

Allow passing in the title from state#313
mvhenten wants to merge 1 commit into
visionmedia:masterfrom
mvhenten:pass-in-title

Conversation

@mvhenten

Copy link
Copy Markdown

This would allow me to pass in "title" from "state". Furthermore, if I do so, I can avoid the dependency on document and use page.js to route server-side rendering.

@samccone

Copy link
Copy Markdown
Contributor

This is a reasonable change, however it is breaking since someone could be using state.title for something else.

For this PR to land we need to do the following:

  1. do a major semver bump.
  2. update the documentation around this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants