Support passing customData to media load request#137
Open
simon816 wants to merge 1 commit intovitalidze:masterfrom
Open
Support passing customData to media load request#137simon816 wants to merge 1 commit intovitalidze:masterfrom
simon816 wants to merge 1 commit intovitalidze:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two issues here:
ChromeCast.loaddid not allow passing acustomDataparametercustomDataserialiser assumed an object with propertypayloadcontaining an object with only string values.From the documentation (https://developers.google.com/cast/docs/media/messages#Load):
There shouldn't be any assumptions about how this is serialised, so providing an
Objectgives the caller the greatest flexibility.Given that the functions to construct the
StandardRequest.Loadobject are package-private and that no public method exists to setcustomData, I believe it's unlikely anyone is relying on the existing serialisation (i.e. wrapped in an object propertypayload).Use case: When reverse engineering the Soundcloud client controller in Chrome, I found it required a
customDataobject on theLOADevent, which I could not set with this library without resorting to reflection.