Added http_realip_module to nginx#1301
Open
LePresidente wants to merge 4 commits intovmware:masterfrom
Open
Conversation
Fixed code block indentation that stopped it from code blocking
Update creating-a-stand-alone-photon-machine-with-cloud-init.md
|
@LePresidente, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction. |
|
@LePresidente, VMware has approved your signed contributor license agreement. |
|
Is there an update on when this change will be merged? |
|
well looks like this won't be in photon 5 either |
Contributor
|
@HarinadhD can you please see if we can add it in our nginx? @bmunro-peralex & @adamus1red, sorry for keeping this pending from such a long time. cc: @tapakund |
gerrit-photon
pushed a commit
that referenced
this pull request
Feb 27, 2023
github links where this was asked: #1301 #1055 Change-Id: I8be5032776e565488d55a21f1cac7aff960106f7 Reviewed-on: http://photon-jenkins.eng.vmware.com:8082/19774 Reviewed-by: Shreenidhi Shedi <sshedi@vmware.com> Tested-by: Shreenidhi Shedi <sshedi@vmware.com>
gerrit-photon
pushed a commit
that referenced
this pull request
Feb 27, 2023
github links where this was asked: #1301 #1055 Change-Id: Ic51e05a72dd454fed4a710e2cf95e443b3722024 Reviewed-on: http://photon-jenkins.eng.vmware.com:8082/19775 Reviewed-by: Shreenidhi Shedi <sshedi@vmware.com> Tested-by: Shreenidhi Shedi <sshedi@vmware.com>
tapakund
pushed a commit
that referenced
this pull request
Mar 20, 2023
github links where this was asked: #1301 #1055 Change-Id: Ic51e05a72dd454fed4a710e2cf95e443b3722024 Reviewed-on: http://photon-jenkins.eng.vmware.com:8082/19775 Reviewed-by: Shreenidhi Shedi <sshedi@vmware.com> Tested-by: Shreenidhi Shedi <sshedi@vmware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #1055
Module documentation can be found here http://nginx.org/en/docs/http/ngx_http_realip_module.html, its useful to retrieve the real ip when nginx is behind another reverse proxy like cloudflare for example.