katifetch: update template to version 13.1 and fix install hooks#59300
Open
ximimoments wants to merge 1 commit intovoid-linux:masterfrom
Open
katifetch: update template to version 13.1 and fix install hooks#59300ximimoments wants to merge 1 commit intovoid-linux:masterfrom
ximimoments wants to merge 1 commit intovoid-linux:masterfrom
Conversation
Contributor
|
This unfortunately doesn't seem to match the package requirements (https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements). Also, the commit message should be |
Bnyro
reviewed
Mar 9, 2026
| pkgname=katifetch | ||
| version=13.1 | ||
| revision=1 | ||
| build_style=gnu-makefile |
Contributor
There was a problem hiding this comment.
Why on earth are you setting the build style to gnu-makefile to package a shell script? Just remove this line.
Also, you skip do_build and override do_install, so the build style doesn't do anything
Bnyro
reviewed
Mar 9, 2026
Comment on lines
+11
to
+14
|
|
||
| do_build() { | ||
| : | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| do_build() { | |
| : | |
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the
katifetchtemplate in Void Linux packages.Changes include:
do_installcommands for scriptstemplatemetadata to reflect current version 13.1Testing the changes
katifetchlocally inmasterdir-x86_64Notes
Local build testing