Skip to content

Don't delete files that are still accessible from the cache #1751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Don't delete files that are still accessible from the cache #1751

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54cca5f
Core: Remove files from cache only if they don't exist
ikelos Sep 9, 2024
8785899
Only remove a file URL with no host and a non-existant path
ikelos Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions volatility3/framework/automagic/symbol_cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,11 +312,18 @@ def update(self, progress_callback=None):

# Missing entries
if missing_locations:
self._database.cursor().execute(
f"DELETE FROM cache WHERE location IN ({','.join(['?'] * len(missing_locations))})",
[x for x in missing_locations],
)
self._database.commit()
for missing_location in missing_locations:
parsed_url = urllib.parse(missing_location)
if (
parsed_url.scheme == "file"
and parsed_url.host == ""
and not os.path.exists(parsed_url.path)
):
self._database.cursor().execute(
f"DELETE FROM cache WHERE location IN ({','.join(['?'] * len(missing_locations))})",
[x for x in missing_locations],
)
self._database.commit()

cache_update = set()
files_to_timestamp = on_disk_locations.intersection(cached_locations)
Expand Down
Loading